fix: include first message in condense summarization #8294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified summarizeConversation to include the first message when creating summary - Added test to verify first message is included in summarization content - Fixes issue where initial task context was lost after condensation Fixes #8293
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| const firstMessage = messages[0] | ||
| // Get messages to summarize, excluding the first message and last N messages | ||
| const messagesToSummarize = getMessagesSinceLastSummary(messages.slice(1, -N_MESSAGES_TO_KEEP)) | ||
| // Get messages to summarize, including the first message but excluding last N messages |
Contributor
Author
There was a problem hiding this comment.
P2: If N_MESSAGES_TO_KEEP === 0, slice(0, -0) yields an empty array, causing no messages to be summarized. Consider normalizing the end index to undefined when N_MESSAGES_TO_KEEP is 0 (e.g., const end = N_MESSAGES_TO_KEEP ? -N_MESSAGES_TO_KEEP : undefined; const messagesToSummarize = getMessagesSinceLastSummary(messages.slice(0, end));).
| import { summarizeConversation, getMessagesSinceLastSummary, N_MESSAGES_TO_KEEP } from "../index" | ||
|
|
||
| // Create a mock ApiHandler for testing | ||
| class MockApiHandler extends BaseProvider { |
Contributor
Author
There was a problem hiding this comment.
P2: This test override uses Anthropic.Messages.MessageParam[], coupling the test to a specific provider SDK. Prefer a provider-agnostic message type to reduce brittleness across providers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #8293 where the condense feature was omitting the initial user message from the summarization process, causing the task context to be lost when resuming after condensation.
Problem
When condensing a conversation:
Solution
Modified the
summarizeConversationfunction to include the first message in the content that gets summarized:messages.slice(1, -N_MESSAGES_TO_KEEP)tomessages.slice(0, -N_MESSAGES_TO_KEEP)Testing
Impact
This ensures that:
Fixes #8293
Important
Fixes issue #8293 by including the first user message in the summarization process to preserve initial task context in
summarizeConversation.summarizeConversation.messages.slice(1, -N_MESSAGES_TO_KEEP)tomessages.slice(0, -N_MESSAGES_TO_KEEP)inindex.ts.condense.spec.tsto verify inclusion of the first message in summarization.This description was created by
for c28700e. You can customize this summary. It will automatically update as commits are pushed.